components/password_manager/core/browser/password_form_manager_unittest.cc - Issue 795183002: PasswordFormManager supports multiple drivers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 795183002: PasswordFormManager supports multiple drivers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment about non-blacklisted forms Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc

index d76086a055b5342aa81bd4127c3bcac12b161175..8d533edf0fc34347c3d661b98f3291fbd55b5a41 100644

--- a/components/password_manager/core/browser/password_form_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc

@@ -952,7 +952,7 @@ TEST_F(PasswordFormManagerTest, TestUpdateIncompleteCredentials) {

// Feed the incomplete credentials to the manager.

std::vector<PasswordForm*> results;

results.push_back(incomplete_form); // Takes ownership.

- form_manager.OnRequestDone(results);

+ form_manager.OnGetPasswordStoreResults(results);

form_manager.ProvisionallySave(

complete_form, PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);

@@ -1344,7 +1344,7 @@ TEST_F(PasswordFormManagerTest, DriverDeletedBeforeStoreDone) {

std::vector<PasswordForm*> results;

results.push_back(form.release());

- form_manager.OnRequestDone(results);

+ form_manager.OnGetPasswordStoreResults(results);

}

} // namespace password_manager