Stricter parsing for rows/cols attribute on textarea

Stricter parsing for rows/cols attribute on textarea
    
According to the latest spec "If the cols attribute is specified, its value
must be a valid non-negative integer greater than zero. If applying the rules
for parsing non-negative integers to the attribute's value results in a number
greater than zero, then the element's character width is that value; otherwise,
it is 20."
The rows attribute is similar but the default value is 2.

With this patch parsing is more strict and above rules are honored.
This was showing as failures here, fixed with this patch:
http://w3c-test.org/html/dom/reflection-forms.html
    
Behavior matches Firefox.

Spec reference:
https://html.spec.whatwg.org/multipage/forms.html#attr-textarea-cols

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187282

[rwlbuis, 2014-12-12 23:07:48]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2014-12-12 23:07:48]

PTAL. This is a lot like my last patch but with more tests this time.

[tkent, 2014-12-15 01:09:29]

https://codereview.chromium.org/795173003/diff/60001/Source/core/dom/Document...
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/795173003/diff/60001/Source/core/dom/Document...
Source/core/dom/Document.cpp:2393: Element* documentElement =
this->documentElement();
Is this related to the topic of this CL?

[rwlbuis, 2014-12-15 13:47:09]

On 2014/12/15 01:09:29, unavailable until Feburuary wrote:
>
https://codereview.chromium.org/795173003/diff/60001/Source/core/dom/Document...
> File Source/core/dom/Document.cpp (right):
> 
>
https://codereview.chromium.org/795173003/diff/60001/Source/core/dom/Document...
> Source/core/dom/Document.cpp:2393: Element* documentElement =
> this->documentElement();
> Is this related to the topic of this CL?

Oops, well spotted, that is from a different patch. Will fix!

[rwlbuis, 2014-12-15 17:34:31]

Patchset #5 (id:80001) has been deleted

[rwlbuis, 2014-12-15 19:38:55]

On 2014/12/15 13:47:09, rwlbuis wrote:
> On 2014/12/15 01:09:29, unavailable until Feburuary wrote:
> >
>
https://codereview.chromium.org/795173003/diff/60001/Source/core/dom/Document...
> > File Source/core/dom/Document.cpp (right):
> > 
> >
>
https://codereview.chromium.org/795173003/diff/60001/Source/core/dom/Document...
> > Source/core/dom/Document.cpp:2393: Element* documentElement =
> > this->documentElement();
> > Is this related to the topic of this CL?
> 
> Oops, well spotted, that is from a different patch. Will fix!

Fixed, and now bots are green too.

[tkent, 2014-12-15 23:51:56]

lgtm

https://codereview.chromium.org/795173003/diff/100001/LayoutTests/fast/dom/HT...
File LayoutTests/fast/dom/HTMLTextAreaElement/script-tests/cols-attribute.js
(right):

https://codereview.chromium.org/795173003/diff/100001/LayoutTests/fast/dom/HT...
LayoutTests/fast/dom/HTMLTextAreaElement/script-tests/cols-attribute.js:1:
description("HTMLTextAreaElement cols attribute test");
Please merge this into the corresponding HTML file.  Separated JS file has no
benefit.  It's a deprecated way to write a layout test.

https://codereview.chromium.org/795173003/diff/100001/LayoutTests/fast/dom/HT...
File LayoutTests/fast/dom/HTMLTextAreaElement/script-tests/rows-attribute.js
(right):

https://codereview.chromium.org/795173003/diff/100001/LayoutTests/fast/dom/HT...
LayoutTests/fast/dom/HTMLTextAreaElement/script-tests/rows-attribute.js:1:
description("HTMLTextAreaElement rows attribute test");
Ditto.

[rwlbuis, 2014-12-16 15:12:23]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-12-16 15:13:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795173003/120001

[commit-bot: I haz the power, 2014-12-16 16:55:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:55:27]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42074)

[rwlbuis, 2014-12-16 17:39:06]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-12-16 17:39:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795173003/120001

[commit-bot: I haz the power, 2014-12-16 18:40:06]

Committed patchset #6 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187282