LayoutTests/fast/dom/HTMLTextAreaElement/rows-attribute.html - Issue 795173003: Stricter parsing for rows/cols attribute on textarea

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLTextAreaElement/rows-attribute.html

Issue 795173003: Stricter parsing for rows/cols attribute on textarea (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLTextAreaElement/cols-attribute-expected.txt ('k') | LayoutTests/fast/dom/HTMLTextAreaElement/rows-attribute-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description("HTMLTextAreaElement rows attribute test");

	9

	10 function rowsAttributeEffect(value)

	11 {

	12 var element = document.createElement("textarea");

	13 element.setAttribute("rows", value);

	14 return element.rows;

	15 }

	16

	17 shouldBe('document.createElement("textarea").rows', '2');

	18

	19 shouldBe('rowsAttributeEffect("")', '2');

	20

	21 shouldBe('rowsAttributeEffect("1")', '1');

	22 shouldBe('rowsAttributeEffect("2")', '2');

	23 shouldBe('rowsAttributeEffect("10")', '10');

	24

	25 shouldBe('rowsAttributeEffect("0")', '2');

	26

	27 shouldBe('rowsAttributeEffect("-1")', '2');

	28

	29 shouldBe('rowsAttributeEffect("1x")', '1');

	30 shouldBe('rowsAttributeEffect("1.")', '1');

	31 shouldBe('rowsAttributeEffect("1.9")', '1');

	32 shouldBe('rowsAttributeEffect("2x")', '2');

	33 shouldBe('rowsAttributeEffect("2.")', '2');

	34 shouldBe('rowsAttributeEffect("2.9")', '2');

	35

	36 shouldBe('rowsAttributeEffect("a")', '2');

	37 shouldBe('rowsAttributeEffect("\v7")', '2');

	38 shouldBe('rowsAttributeEffect(" 7")', '7');

	39

	40 var arabicIndicDigitOne = String.fromCharCode(0x661);

	41 shouldBe('rowsAttributeEffect(arabicIndicDigitOne)', '2');

	42 shouldBe('rowsAttributeEffect("2" + arabicIndicDigitOne)', '2');

	43

	44 shouldBe('rowsAttributeEffect("2147483647")', '2147483647');

	45 shouldBe('rowsAttributeEffect("2147483648")', '2');

	46 shouldBe('rowsAttributeEffect("4294967295")', '2');

	47 shouldBe('rowsAttributeEffect("4294967296")', '2');

	48 </script>

	49 </body>

	50 </html>

OLD	NEW