Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7738)

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view.h

Issue 795053003: [Password Manager] Close the bubble when fullscreen state gets change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Vasilii's review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/zoom_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view.h b/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
index 0f1752c44aab0e2eafc93ffc72cbd34d79199496..9c0448809308cf3f222918fc7c213d5aaf55a50e 100644
--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
@@ -9,6 +9,7 @@
#include "base/gtest_prod_util.h"
#include "base/timer/timer.h"
#include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
+#include "chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "extensions/browser/extension_icon_image.h"
@@ -29,9 +30,8 @@ class ImageButton;
} // namespace views
// View used to display the zoom percentage when it has changed.
-class ZoomBubbleView : public views::BubbleDelegateView,
+class ZoomBubbleView : public ManagedFullScreenBubbleDelegateView,
public views::ButtonListener,
- public content::NotificationObserver,
public ImmersiveModeController::Observer,
public extensions::IconImage::Observer {
public:
@@ -89,7 +89,8 @@ class ZoomBubbleView : public views::BubbleDelegateView,
// resetting the timer if necessary.
void Refresh();
- void Close();
+ // ManagedFullScreenBubbleDelegateView:
Peter Kasting 2014/12/19 22:11:35 Nit: Normally we try to encourage placing all over
Pritam Nikam 2014/12/22 08:19:09 Done.
+ void Close() override;
// Sets information about the extension that initiated the zoom change.
// Calling this method asserts that the extension |extension| did initiate
@@ -119,11 +120,6 @@ class ZoomBubbleView : public views::BubbleDelegateView,
void Init() override;
void WindowClosing() override;
- // content::NotificationObserver method.
- void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
-
// ImmersiveModeController::Observer methods.
void OnImmersiveRevealStarted() override;
void OnImmersiveModeControllerDestroyed() override;
@@ -157,9 +153,6 @@ class ZoomBubbleView : public views::BubbleDelegateView,
// Not owned.
ImmersiveModeController* immersive_mode_controller_;
- // Used to register for fullscreen change notifications.
- content::NotificationRegistrar registrar_;
-
DISALLOW_COPY_AND_ASSIGN(ZoomBubbleView);
};

Powered by Google App Engine
This is Rietveld 408576698