[Password Manager] Close the bubble when fullscreen state gets change.

chrome/browser/ui/views/location_bar/zoom_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ZOOM_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ZOOM_BUBBLE_VIEW_H_
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
+#include "chrome/browser/ui/views/managed_full_screen_bubble_delegate_view.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "extensions/browser/extension_icon_image.h"
 #include "ui/views/bubble/bubble_delegate.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/label.h"
 
 class FullscreenController;
 
 namespace content {
 class NotificationDetails;
 class NotificationSource;
 class WebContents;
 }
 
 namespace views {
 class ImageButton;
 }  // namespace views
 
 // View used to display the zoom percentage when it has changed.
-class ZoomBubbleView : public views::BubbleDelegateView,
+class ZoomBubbleView : public ManagedFullScreenBubbleDelegateView,
                        public views::ButtonListener,
-                       public content::NotificationObserver,
                        public ImmersiveModeController::Observer,
                        public extensions::IconImage::Observer {
  public:
   // Shows the bubble and automatically closes it after a short time period if
   // |auto_close| is true.
   static void ShowBubble(content::WebContents* web_contents,
                          bool auto_close);
 
   // Closes the showing bubble (if one exists).
   static void CloseBubble();
@@ skipping 37 matching lines @@
   // If the bubble is not anchored to a view, places the bubble in the top
   // right (left in RTL) of the |screen_bounds| that contain |web_contents_|'s
   // browser window. Because the positioning is based on the size of the
   // bubble, this must be called after the bubble is created.
   void AdjustForFullscreen(const gfx::Rect& screen_bounds);
 
   // Refreshes the bubble by changing the zoom percentage appropriately and
   // resetting the timer if necessary.
   void Refresh();
 
-  void Close();
+  // ManagedFullScreenBubbleDelegateView:

[Peter Kasting, 2014/12/19 22:11:35]

Nit: Normally we try to encourage placing all overrides together, in the same
order as the parent classes are declared.  In this case things are already
scattered around pretty badly and we list overrides for classes that aren't
direct parents (e.g. views::View), so there's really no good place to put this,
but if you feel inclined to clean all this up you're welcome to do so.

[Pritam Nikam, 2014/12/22 08:19:09]

Done.

+  void Close() override;
 
   // Sets information about the extension that initiated the zoom change.
   // Calling this method asserts that the extension |extension| did initiate
   // the zoom change.
   void SetExtensionInfo(const extensions::Extension* extension);
 
   // Starts a timer which will close the bubble if |auto_close_| is true.
   void StartTimerIfNecessary();
 
   // Stops the auto-close timer.
   void StopTimer();
 
   // extensions::IconImage::Observer overrides:
   void OnExtensionIconImageChanged(extensions::IconImage* /* image */) override;
 
   // views::View methods.
   void OnMouseEntered(const ui::MouseEvent& event) override;
   void OnMouseExited(const ui::MouseEvent& event) override;
 
   // ui::EventHandler method.
   void OnGestureEvent(ui::GestureEvent* event) override;
 
   // views::ButtonListener method.
   void ButtonPressed(views::Button* sender, const ui::Event& event) override;
 
   // views::BubbleDelegateView method.
   void Init() override;
   void WindowClosing() override;
 
-  // content::NotificationObserver method.
-  void Observe(int type,
-               const content::NotificationSource& source,
-               const content::NotificationDetails& details) override;
-
   // ImmersiveModeController::Observer methods.
   void OnImmersiveRevealStarted() override;
   void OnImmersiveModeControllerDestroyed() override;
 
   ZoomBubbleExtensionInfo extension_info_;
 
   // Singleton instance of the zoom bubble. The zoom bubble can only be shown on
   // the active browser window, so there is no case in which it will be shown
   // twice at the same time.
   static ZoomBubbleView* zoom_bubble_;
@@ skipping 13 matching lines @@
   content::WebContents* web_contents_;
 
   // Whether the currently displayed bubble will automatically close.
   bool auto_close_;
 
   // The immersive mode controller for the BrowserView containing
   // |web_contents_|.
   // Not owned.
   ImmersiveModeController* immersive_mode_controller_;
 
-  // Used to register for fullscreen change notifications.
-  content::NotificationRegistrar registrar_;
-
   DISALLOW_COPY_AND_ASSIGN(ZoomBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_ZOOM_BUBBLE_VIEW_H_