Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 794923002: Subzero: Use llvm::ilist<> for PhiList and AssignList. (Closed)

Created:
6 years ago by Jim Stichnoth
Modified:
6 years ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Use llvm::ilist<> for PhiList and AssignList. This is toward the goal of pulling non-POD fields out of the CfgNode class so that CfgNode can be arena-allocated and not leak memory. For now, PhiList and AssignList are defined as InstList. Ideally, they would be ilist<> of InstPhi and InstAssign, but SFINAE happens. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1502e59a21e77f4f2a32cdef42201291e52899bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -32 lines) Patch
M src/IceCfgNode.cpp View 13 chunks +27 lines, -23 lines 0 comments Download
M src/IceDefs.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/IceOperand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
6 years ago (2014-12-11 00:46:58 UTC) #2
jvoung (off chromium)
lgtm
6 years ago (2014-12-11 17:00:33 UTC) #3
Jim Stichnoth
6 years ago (2014-12-11 17:22:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1502e59a21e77f4f2a32cdef42201291e52899bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698