Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData.

chrome/browser/notifications/desktop_notification_service.h

Index: chrome/browser/notifications/desktop_notification_service.h
diff --git a/chrome/browser/notifications/desktop_notification_service.h b/chrome/browser/notifications/desktop_notification_service.h
index 3071045509907f0f4fb2319c7b0b2f3d5c64e8e2..864d1591c9fcebe14211e4c89df9ba590d7bb364 100644
--- a/chrome/browser/notifications/desktop_notification_service.h
+++ b/chrome/browser/notifications/desktop_notification_service.h
@@ -36,7 +36,7 @@ class Profile;
 
 namespace content {
 class DesktopNotificationDelegate;
-struct ShowDesktopNotificationHostMsgParams;
+struct PlatformNotificationData;
 }
 
 #if defined(ENABLE_EXTENSIONS)
@@ -80,7 +80,9 @@ class DesktopNotificationService : public PermissionContextBase
   // Show a desktop notification. If |cancel_callback| is non-null, it's set to
   // a callback which can be used to cancel the notification.
   void ShowDesktopNotification(
-      const content::ShowDesktopNotificationHostMsgParams& params,
+      const GURL& origin,
+      const SkBitmap& icon,

[dewittj, 2014/12/10 21:57:49]

Is it possible to use gfx::Image in this API so that only the consumers need to
change when we support multiple scale factors?

[Peter Beverloo, 2014/12/10 22:06:37]

Firstly, this call is going away entirely after
https://codereview.chromium.org/787193002/, but you're talking in general.

There are two parts to this:

  (1) The current conversion from SkBitmap to gfx::Image, which only supports 1x
scale. PlatformNotificationServiceImpl::CreateNotificationFromData will be the
only place where this conversion gets done, regardless of the code path. We
cannot pass gfx::Images over IPC.

  (2) Allowing developers to specify multiple icons, depending on resolution.
We'll make the selection in the NotificationImageLoader and only pass through a
single SkBitmap to the browser process, whilst storing all available images in
the PlatformNotificationData.

Does this answer your question?

+      const content::PlatformNotificationData& notification_data,
       int render_process_id,
       scoped_ptr<content::DesktopNotificationDelegate> delegate,
       base::Closure* cancel_callback);