Remove ShowDesktopNotificationHostMsgParams in favor of PlatformNotificationData.

chrome/browser/notifications/desktop_notification_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_DESKTOP_NOTIFICATION_SERVICE_H_
 #define CHROME_BROWSER_NOTIFICATIONS_DESKTOP_NOTIFICATION_SERVICE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 18 matching lines @@
 #include "extensions/browser/extension_registry_observer.h"
 #endif
 
 class Notification;
 class NotificationDelegate;
 class NotificationUIManager;
 class Profile;
 
 namespace content {
 class DesktopNotificationDelegate;
-struct ShowDesktopNotificationHostMsgParams;
+struct PlatformNotificationData;
 }
 
 #if defined(ENABLE_EXTENSIONS)
 namespace extensions {
 class ExtensionRegistry;
 }
 #endif
 
 namespace gfx {
 class Image;
@@ skipping 23 matching lines @@
   void RequestNotificationPermission(
       content::WebContents* web_contents,
       const PermissionRequestID& request_id,
       const GURL& requesting_origin,
       bool user_gesture,
       const base::Callback<void(bool)>& result_callback);
 
   // Show a desktop notification. If |cancel_callback| is non-null, it's set to
   // a callback which can be used to cancel the notification.
   void ShowDesktopNotification(
-      const content::ShowDesktopNotificationHostMsgParams& params,
+      const GURL& origin,
+      const SkBitmap& icon,

[dewittj, 2014/12/10 21:57:49]

Is it possible to use gfx::Image in this API so that only the consumers need to
change when we support multiple scale factors?

[Peter Beverloo, 2014/12/10 22:06:37]

Firstly, this call is going away entirely after
https://codereview.chromium.org/787193002/, but you're talking in general.

There are two parts to this:

  (1) The current conversion from SkBitmap to gfx::Image, which only supports 1x
scale. PlatformNotificationServiceImpl::CreateNotificationFromData will be the
only place where this conversion gets done, regardless of the code path. We
cannot pass gfx::Images over IPC.

  (2) Allowing developers to specify multiple icons, depending on resolution.
We'll make the selection in the NotificationImageLoader and only pass through a
single SkBitmap to the browser process, whilst storing all available images in
the PlatformNotificationData.

Does this answer your question?

+      const content::PlatformNotificationData& notification_data,
       int render_process_id,
       scoped_ptr<content::DesktopNotificationDelegate> delegate,
       base::Closure* cancel_callback);
 
   // Returns true if the notifier with |notifier_id| is allowed to send
   // notifications.
   bool IsNotifierEnabled(const message_center::NotifierId& notifier_id);
 
   // Updates the availability of the notifier.
   void SetNotifierEnabled(const message_center::NotifierId& notifier_id,
@@ skipping 48 matching lines @@
   // An observer to listen when extension is uninstalled.
   ScopedObserver<extensions::ExtensionRegistry,
                  extensions::ExtensionRegistryObserver>
       extension_registry_observer_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(DesktopNotificationService);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_DESKTOP_NOTIFICATION_SERVICE_H_