move v8_use_external_startup_data to standalone.gypi

move v8_use_external_startup_data to standalone.gypi

This allows the setting to be overridable by embedders,
at the cost of forcing embedders that don't build v8
using standalone.gypi to add this setting to their build
config.

BUG=chromium:421063
LOG=Y

[Mostyn Bramley-Moore, 2014-12-11 13:12:03]

mostynb@opera.com changed reviewers:
+ jkummerow@chromium.org

[Mostyn Bramley-Moore, 2014-12-11 13:12:54]

@Jakob: here's my proposed adjustment from the discussion in
https://codereview.chromium.org/789673008/

[rmcilroy, 2014-12-11 13:24:33]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2014-12-11 13:24:34]

https://codereview.chromium.org/794583002/diff/1/build/features.gypi
File build/features.gypi (left):

https://codereview.chromium.org/794583002/diff/1/build/features.gypi#oldcode100
build/features.gypi:100: }],
This needs to still be here since we want to define V8_USE_EXTERNAL_STARTUP_DATA
even when not doing a standalone build

[Jakob Kummerow, 2014-12-11 13:33:42]

LGTM if you address Ross' comment (i.e. undo half of the patch).

[Mostyn Bramley-Moore, 2014-12-11 13:36:54]

Done.  I left a comment in features.gypi - should I put the same comment in
standalone.gypi ?

https://codereview.chromium.org/794583002/diff/1/build/features.gypi
File build/features.gypi (left):

https://codereview.chromium.org/794583002/diff/1/build/features.gypi#oldcode100
build/features.gypi:100: }],
On 2014/12/11 13:24:34, rmcilroy wrote:
> This needs to still be here since we want to define
V8_USE_EXTERNAL_STARTUP_DATA
> even when not doing a standalone build

Done.

[Jakob Kummerow, 2014-12-11 14:07:41]

Nope, we don't need a duplicate comment. Instead, drop the duplicate condition.

Btw, if you fully specify the bug (BUG=chromium:421063), then bugdroid can
automatically update the bug with the commit information. AFAIK that doesn't
work when you leave out the "chromium:" part.

https://codereview.chromium.org/794583002/diff/20001/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/794583002/diff/20001/build/standalone.gypi#ne...
build/standalone.gypi:456: ['v8_use_external_startup_data==1', {
What's this still doing here?

[Mostyn Bramley-Moore, 2014-12-11 14:22:08]

https://codereview.chromium.org/794583002/diff/20001/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/794583002/diff/20001/build/standalone.gypi#ne...
build/standalone.gypi:456: ['v8_use_external_startup_data==1', {
On 2014/12/11 14:07:41, Jakob wrote:
> What's this still doing here?

Done.

[Jakob Kummerow, 2014-12-11 14:29:43]

lgtm

[Mostyn Bramley-Moore, 2014-12-11 14:53:17]

Thanks- can you please land this for me? (IIRC v8 doesn't have a commit queue.)

[Jakob Kummerow, 2014-12-11 15:00:14]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2014-12-11 15:00:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/794583002/40001

[commit-bot: I haz the power, 2014-12-11 15:27:42]

Committed patchset #3 (id:40001)