Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: build/standalone.gypi

Issue 794583002: move v8_use_external_startup_data to standalone.gypi (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add back the define in features.gypi, with a comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/features.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 # debug. This may still be 2x slower than Release (or worse). 86 # debug. This may still be 2x slower than Release (or worse).
87 # 2 - Turn on optimizations, and also #undef DEBUG / #define NDEBUG 87 # 2 - Turn on optimizations, and also #undef DEBUG / #define NDEBUG
88 # (but leave V8_ENABLE_CHECKS and most other assertions enabled. 88 # (but leave V8_ENABLE_CHECKS and most other assertions enabled.
89 # This may cause some v8 tests to fail in the Debug configuration. 89 # This may cause some v8 tests to fail in the Debug configuration.
90 # This roughly matches the performance of a Release build and can 90 # This roughly matches the performance of a Release build and can
91 # be used by embedders that need to build their own code as debug 91 # be used by embedders that need to build their own code as debug
92 # but don't want or need a debug version of V8. This should produce 92 # but don't want or need a debug version of V8. This should produce
93 # near-release speeds. 93 # near-release speeds.
94 'v8_optimized_debug%': 0, 94 'v8_optimized_debug%': 0,
95 95
96 # Use external files for startup data blobs:
97 # the JS builtins sources and the start snapshot.
98 'v8_use_external_startup_data%': 0,
99
96 # Relative path to icu.gyp from this file. 100 # Relative path to icu.gyp from this file.
97 'icu_gyp_path': '../third_party/icu/icu.gyp', 101 'icu_gyp_path': '../third_party/icu/icu.gyp',
98 102
99 'conditions': [ 103 'conditions': [
100 ['(v8_target_arch=="arm" and host_arch!="arm") or \ 104 ['(v8_target_arch=="arm" and host_arch!="arm") or \
101 (v8_target_arch=="arm64" and host_arch!="arm64") or \ 105 (v8_target_arch=="arm64" and host_arch!="arm64") or \
102 (v8_target_arch=="mipsel" and host_arch!="mipsel") or \ 106 (v8_target_arch=="mipsel" and host_arch!="mipsel") or \
103 (v8_target_arch=="mips64el" and host_arch!="mips64el") or \ 107 (v8_target_arch=="mips64el" and host_arch!="mips64el") or \
104 (v8_target_arch=="x64" and host_arch!="x64") or \ 108 (v8_target_arch=="x64" and host_arch!="x64") or \
105 (OS=="android" or OS=="qnx")', { 109 (OS=="android" or OS=="qnx")', {
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 ['CC.host', '$(CC)'], 446 ['CC.host', '$(CC)'],
443 ['CXX.host', '$(CXX)'], 447 ['CXX.host', '$(CXX)'],
444 ], 448 ],
445 }], 449 }],
446 ['clang==1 and OS=="win"', { 450 ['clang==1 and OS=="win"', {
447 'make_global_settings': [ 451 'make_global_settings': [
448 # On Windows, gyp's ninja generator only looks at CC. 452 # On Windows, gyp's ninja generator only looks at CC.
449 ['CC', '<(make_clang_dir)/bin/clang-cl'], 453 ['CC', '<(make_clang_dir)/bin/clang-cl'],
450 ], 454 ],
451 }], 455 }],
456 ['v8_use_external_startup_data==1', {
Jakob Kummerow 2014/12/11 14:07:41 What's this still doing here?
Mostyn Bramley-Moore 2014/12/11 14:22:08 Done.
457 'target_defaults': {
458 'defines': ['V8_USE_EXTERNAL_STARTUP_DATA',],
459 },
460 }],
452 ], 461 ],
453 } 462 }
OLDNEW
« no previous file with comments | « build/features.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698