Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 794413003: Run gn format on all gni files (gn version 307087) (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan, jamesr
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Run gn format on all gni files (gn version 307087) Change generated by running the following command: for x in `git ls-files *.gni`; do gn format --in-place $x; done This came up as an issue in https://codereview.chromium.org/801523002/, but I didn't want to add noise to that CL. R=qsr@chromium.org, qsr Committed: https://chromium.googlesource.com/external/mojo/+/4c3ffa28401a846c58c6c4eea2afe34cf0d3086f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -335 lines) Patch
M mojo/edk/mojo_edk.gni View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/public/mojo_sdk.gni View 3 chunks +6 lines, -7 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 5 chunks +27 lines, -32 lines 0 comments Download
M sky/engine/bindings/bindings.gni View 2 chunks +18 lines, -17 lines 0 comments Download
M sky/engine/bindings/core/idl.gni View 2 chunks +9 lines, -15 lines 0 comments Download
M sky/engine/bindings/core/v8/generated.gni View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/bindings/idl.gni View 1 chunk +4 lines, -6 lines 0 comments Download
M sky/engine/bindings/scripts/scripts.gni View 5 chunks +33 lines, -27 lines 0 comments Download
M sky/engine/bindings/templates/templates.gni View 1 chunk +11 lines, -13 lines 0 comments Download
M sky/engine/build/scripts/scripts.gni View 6 chunks +39 lines, -34 lines 0 comments Download
M sky/engine/config.gni View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +177 lines, -173 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blundell
qsr: For review. jamesr: fyi.
6 years ago (2014-12-12 07:27:23 UTC) #1
qsr
lgtm
6 years ago (2014-12-12 08:47:32 UTC) #2
blundell
6 years ago (2014-12-12 08:51:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c3ffa28401a846c58c6c4eea2afe34cf0d3086f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698