Source/core/rendering/RenderBlock.cpp - Issue 79433004: Display anonymous regions in DRT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 79433004: Display anonymous regions in DRT (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address review comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index 3da6c555ebdc58450e6d9cd315ffce4d38ffa06e..d12d77104fc5429990677f695474653998c3a81f 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -5702,10 +5702,8 @@ bool RenderBlock::hasMarginAfterQuirk(const RenderBox* child) const

const char* RenderBlock::renderName() const

{

if (isBody())

- return "RenderBody"; // FIXME: Temporary hack until we know that the regression tests pass.

Julien - ping for review 2013/11/24 22:44:34 This is still a hack (see r4691 that introduced it

+ return "RenderBody";

- if (isRenderNamedFlowFragmentContainer())

- return "RenderRegion";

if (isFloating())

return "RenderBlock (floating)";

if (isOutOfFlowPositioned())