Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: Source/core/rendering/RenderBlock.cpp

Issue 79433004: Display anonymous regions in DRT (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 5684 matching lines...) Expand 10 before | Expand all | Expand 10 after
5695 return child->isRenderBlock() ? toRenderBlock(child)->hasMarginBeforeQui rk() : child->style()->hasMarginBeforeQuirk(); 5695 return child->isRenderBlock() ? toRenderBlock(child)->hasMarginBeforeQui rk() : child->style()->hasMarginBeforeQuirk();
5696 5696
5697 // The child is perpendicular to us and box sides are never quirky in html.c ss, and we don't really care about 5697 // The child is perpendicular to us and box sides are never quirky in html.c ss, and we don't really care about
5698 // whether or not authors specified quirky ems, since they're an implementat ion detail. 5698 // whether or not authors specified quirky ems, since they're an implementat ion detail.
5699 return false; 5699 return false;
5700 } 5700 }
5701 5701
5702 const char* RenderBlock::renderName() const 5702 const char* RenderBlock::renderName() const
5703 { 5703 {
5704 if (isBody()) 5704 if (isBody())
5705 return "RenderBody"; // FIXME: Temporary hack until we know that the reg ression tests pass. 5705 return "RenderBody";
Julien - ping for review 2013/11/24 22:44:34 This is still a hack (see r4691 that introduced it
5706 5706
5707 if (isRenderNamedFlowFragmentContainer())
5708 return "RenderRegion";
5709 if (isFloating()) 5707 if (isFloating())
5710 return "RenderBlock (floating)"; 5708 return "RenderBlock (floating)";
5711 if (isOutOfFlowPositioned()) 5709 if (isOutOfFlowPositioned())
5712 return "RenderBlock (positioned)"; 5710 return "RenderBlock (positioned)";
5713 if (isAnonymousColumnsBlock()) 5711 if (isAnonymousColumnsBlock())
5714 return "RenderBlock (anonymous multi-column)"; 5712 return "RenderBlock (anonymous multi-column)";
5715 if (isAnonymousColumnSpanBlock()) 5713 if (isAnonymousColumnSpanBlock())
5716 return "RenderBlock (anonymous multi-column span)"; 5714 return "RenderBlock (anonymous multi-column span)";
5717 if (isAnonymousBlock()) 5715 if (isAnonymousBlock())
5718 return "RenderBlock (anonymous)"; 5716 return "RenderBlock (anonymous)";
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
5788 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Render Object* obj) const 5786 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Render Object* obj) const
5789 { 5787 {
5790 showRenderObject(); 5788 showRenderObject();
5791 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box()) 5789 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box())
5792 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1); 5790 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1);
5793 } 5791 }
5794 5792
5795 #endif 5793 #endif
5796 5794
5797 } // namespace WebCore 5795 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698