Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 794293002: cc: Unify BeginRetroFrames and non-RetroFrame paths in scheduler. [WIP] (Closed)

Created:
6 years ago by mithro-old
Modified:
5 years, 6 months ago
Reviewers:
sunnyps, brianderson
CC:
simonhong
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Unify BeginRetroFrames and non-RetroFrame paths in scheduler. [WIP] This patch unifies the path to running BeginImplFrame no matter when it comes in. The theory works as follows; * Put BeginFrameArgs into a FIFO. * Scheduler processing of FIFO (which could be now). FIFO processing works as follows; - While **more** than one args in the FIFO * Discard first args if they have expired - Now we either have; * Only on args left (which could be expired). * An unexpired args. - We now process them like we use too. The idea behind the FIFO processing is; * We never only want to discard the last BeginFrameArgs we have because we don't have any mechanism which stops us discarding all of them. Plus, we don't really know when the next one will turn up either. * If we have multiple args, then its safe to discard the expired ones. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -260 lines) Patch
M cc/scheduler/scheduler.cc View 14 chunks +236 lines, -256 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mithro-old
6 years ago (2014-12-11 19:17:51 UTC) #2
At Brian's request, here is the other patch which begat our discussion about
when the correct time to run a BeginMainFrame discussion came from.

Tim

Powered by Google App Engine
This is Rietveld 408576698