Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 794263002: Cull pushCull and popCull from Skia. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
f(malita), mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cull pushCull and popCull from Skia. These calls are unused and going away. Waiting on crrev.com/796083002. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f0f14113431ace669f278fdd97b50950f2cf4c80

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix debugger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -256 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M include/core/SkCanvas.h View 4 chunks +0 lines, -20 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 4 chunks +2 lines, -67 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +2 lines, -12 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkRecords.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 6 chunks +3 lines, -19 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 2 chunks +2 lines, -33 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 2 chunks +0 lines, -26 lines 0 comments Download
M tests/RecordPatternTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
6 years ago (2014-12-11 18:58:50 UTC) #2
reed1
api lgtm
6 years ago (2014-12-11 19:02:28 UTC) #4
f(malita)
lgtm *sniffle* https://codereview.chromium.org/794263002/diff/1/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (left): https://codereview.chromium.org/794263002/diff/1/debugger/QT/SkDebuggerGUI.cpp#oldcode816 debugger/QT/SkDebuggerGUI.cpp:816: 0 == strcmp("PopCull", (*commands)[i].c_str())) { Let's leave ...
6 years ago (2014-12-11 19:15:49 UTC) #5
mtklein
https://codereview.chromium.org/794263002/diff/1/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (left): https://codereview.chromium.org/794263002/diff/1/debugger/QT/SkDebuggerGUI.cpp#oldcode816 debugger/QT/SkDebuggerGUI.cpp:816: 0 == strcmp("PopCull", (*commands)[i].c_str())) { On 2014/12/11 19:15:49, Florin ...
6 years ago (2014-12-11 19:24:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794263002/20001
6 years ago (2014-12-12 15:19:43 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-12 16:46:32 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f0f14113431ace669f278fdd97b50950f2cf4c80

Powered by Google App Engine
This is Rietveld 408576698