Source/platform/heap/ThreadState.h - Issue 794223003: Cheaper thread-safe atomic initialization of static references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/ThreadState.h

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add type check for initial value Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/ThreadState.h

diff --git a/Source/platform/heap/ThreadState.h b/Source/platform/heap/ThreadState.h

index e7775ea86c871b0e7e511134abb3d78b3a41fc09..c94e4b68d885d3f960573290a905b3df38ead42b 100644

--- a/Source/platform/heap/ThreadState.h

+++ b/Source/platform/heap/ThreadState.h

@@ -473,7 +473,7 @@ public:

// List of global persistent roots not owned by any particular thread.

// globalRootsMutex must be acquired before any modifications.

- static PersistentNode* globalRoots();

+ static PersistentNode& globalRoots();

static Mutex& globalRootsMutex();

// Visit local thread stack and trace all pointers conservatively.

« no previous file with comments | « Source/platform/heap/HeapTest.cpp ('k') | Source/platform/heap/ThreadState.cpp » ('j') | Source/wtf/Threading.h » ('J')