Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2440)

Unified Diff: Source/platform/heap/HeapTest.cpp

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add type check for initial value Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/heap/HeapTest.cpp
diff --git a/Source/platform/heap/HeapTest.cpp b/Source/platform/heap/HeapTest.cpp
index 802db688cb7d653c8f4a46baac9a4f88d2be9049..c87ee5076130bf93063de4c2a61d4c9e1f183b02 100644
--- a/Source/platform/heap/HeapTest.cpp
+++ b/Source/platform/heap/HeapTest.cpp
@@ -4778,13 +4778,13 @@ TEST(HeapTest, IndirectStrongToWeak)
static Mutex& mainThreadMutex()
{
- AtomicallyInitializedStatic(Mutex&, mainMutex = *new Mutex);
+ AtomicallyInitializedStaticReference(Mutex, mainMutex, new Mutex);
return mainMutex;
}
static ThreadCondition& mainThreadCondition()
{
- AtomicallyInitializedStatic(ThreadCondition&, mainCondition = *new ThreadCondition);
+ AtomicallyInitializedStaticReference(ThreadCondition, mainCondition, new ThreadCondition);
return mainCondition;
}
@@ -4801,13 +4801,13 @@ static void wakeMainThread()
static Mutex& workerThreadMutex()
{
- AtomicallyInitializedStatic(Mutex&, workerMutex = *new Mutex);
+ AtomicallyInitializedStaticReference(Mutex, workerMutex, new Mutex);
return workerMutex;
}
static ThreadCondition& workerThreadCondition()
{
- AtomicallyInitializedStatic(ThreadCondition&, workerCondition = *new ThreadCondition);
+ AtomicallyInitializedStaticReference(ThreadCondition, workerCondition, new ThreadCondition);
return workerCondition;
}
@@ -5083,7 +5083,7 @@ TEST(HeapTest, GarbageCollectionDuringMixinConstruction)
static RecursiveMutex& recursiveMutex()
{
- AtomicallyInitializedStatic(RecursiveMutex&, recursiveMutex = *new RecursiveMutex);
+ AtomicallyInitializedStaticReference(RecursiveMutex, recursiveMutex, new RecursiveMutex);
return recursiveMutex;
}

Powered by Google App Engine
This is Rietveld 408576698