Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: src/trusted/reverse_service/reverse_socket.cc

Issue 7942008: NaCl repo side changes to make crash reporting more reliable. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/reverse_service/reverse_socket.h ('k') | src/trusted/service_runtime/sel_ldr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/reverse_service/reverse_socket.cc
===================================================================
--- src/trusted/reverse_service/reverse_socket.cc (revision 6725)
+++ src/trusted/reverse_service/reverse_socket.cc (working copy)
@@ -23,7 +23,9 @@
rev_service_ = NULL;
}
-bool ReverseSocket::StartService(void* server_instance_data) {
+bool ReverseSocket::StartServiceCb(void (*exit_cb)(void *server_instance_data,
+ int server_loop_ret),
+ void* server_instance_data) {
NaClLog(4, "Entered ReverseSocket::StartService\n");
nacl::scoped_ptr_malloc<NaClSimpleRevService> rev_service_tmp(
reinterpret_cast<NaClSimpleRevService*>(
@@ -49,8 +51,9 @@
NaClLog(4, "ReverseSocket::StartService: invoking ConnectAndSpawnHandler\n");
if (0 != (*NACL_VTBL(NaClSimpleRevService, rev_service_)->
- ConnectAndSpawnHandler)(rev_service_,
- server_instance_data)) {
+ ConnectAndSpawnHandlerCb)(rev_service_,
+ exit_cb,
+ server_instance_data)) {
NaClLog(4, "FAILURE: Leaving ReverseSocket::StartService\n");
return false;
}
@@ -60,4 +63,8 @@
return true;
}
+bool ReverseSocket::StartService(void* server_instance_data) {
+ return StartServiceCb(NULL, server_instance_data);
+}
+
} // namespace nacl
« no previous file with comments | « src/trusted/reverse_service/reverse_socket.h ('k') | src/trusted/service_runtime/sel_ldr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698