Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 794133002: [Password Manager] Add UMA signals to understand how often the password form submit navigate… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index bae9ce24b7ac5cda3806a767fbfeeee70744d673..b49ffe1fd4d99554751cc2620270624a80396dfd 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -76,6 +76,7 @@ class ChromePasswordManagerClient
bool IsOffTheRecord() override;
password_manager::PasswordManager* GetPasswordManager() override;
autofill::AutofillManager* GetAutofillManagerForMainFrame() override;
+ void OnPasswordFormsParsed() override;
// Hides any visible generation UI.
void HidePasswordGenerationPopup();
@@ -170,6 +171,10 @@ class ChromePasswordManagerClient
// reporting.
bool sync_credential_was_filtered_;
+ // Visible URL for password form being parsed, i.e. of the main frame (seen in
vabr (Chromium) 2014/12/12 16:24:00 Please just call the variable: main_frame_url_ and
Pritam Nikam 2014/12/15 07:41:49 Done.
+ // the Omnibox).
+ GURL password_form_visible_URL_;
+
DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
};

Powered by Google App Engine
This is Rietveld 408576698