Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 794133002: [Password Manager] Add UMA signals to understand how often the password form submit navigate… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "components/password_manager/content/browser/content_credential_manager _dispatcher.h" 10 #include "components/password_manager/content/browser/content_credential_manager _dispatcher.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 bool IsPasswordSyncEnabled( 69 bool IsPasswordSyncEnabled(
70 password_manager::CustomPassphraseState state) override; 70 password_manager::CustomPassphraseState state) override;
71 void OnLogRouterAvailabilityChanged(bool router_can_be_used) override; 71 void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;
72 void LogSavePasswordProgress(const std::string& text) const override; 72 void LogSavePasswordProgress(const std::string& text) const override;
73 bool IsLoggingActive() const override; 73 bool IsLoggingActive() const override;
74 bool WasLastNavigationHTTPError() const override; 74 bool WasLastNavigationHTTPError() const override;
75 bool DidLastPageLoadEncounterSSLErrors() override; 75 bool DidLastPageLoadEncounterSSLErrors() override;
76 bool IsOffTheRecord() override; 76 bool IsOffTheRecord() override;
77 password_manager::PasswordManager* GetPasswordManager() override; 77 password_manager::PasswordManager* GetPasswordManager() override;
78 autofill::AutofillManager* GetAutofillManagerForMainFrame() override; 78 autofill::AutofillManager* GetAutofillManagerForMainFrame() override;
79 void OnPasswordFormsParsed() override;
79 80
80 // Hides any visible generation UI. 81 // Hides any visible generation UI.
81 void HidePasswordGenerationPopup(); 82 void HidePasswordGenerationPopup();
82 83
83 static void CreateForWebContentsWithAutofillClient( 84 static void CreateForWebContentsWithAutofillClient(
84 content::WebContents* contents, 85 content::WebContents* contents,
85 autofill::AutofillClient* autofill_client); 86 autofill::AutofillClient* autofill_client);
86 87
87 // Observer for PasswordGenerationPopup events. Used for testing. 88 // Observer for PasswordGenerationPopup events. Used for testing.
88 void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer); 89 void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer);
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 // True if |this| is registered with some LogRouter which can accept logs. 164 // True if |this| is registered with some LogRouter which can accept logs.
164 bool can_use_log_router_; 165 bool can_use_log_router_;
165 166
166 // How to handle the sync credential in ShouldFilterAutofillResult(). 167 // How to handle the sync credential in ShouldFilterAutofillResult().
167 AutofillForSyncCredentialsState autofill_sync_state_; 168 AutofillForSyncCredentialsState autofill_sync_state_;
168 169
169 // If the sync credential was filtered during autofill. Used for statistics 170 // If the sync credential was filtered during autofill. Used for statistics
170 // reporting. 171 // reporting.
171 bool sync_credential_was_filtered_; 172 bool sync_credential_was_filtered_;
172 173
174 // Visible URL for password form being parsed, i.e. of the main frame (seen in
vabr (Chromium) 2014/12/12 16:24:00 Please just call the variable: main_frame_url_ and
Pritam Nikam 2014/12/15 07:41:49 Done.
175 // the Omnibox).
176 GURL password_form_visible_URL_;
177
173 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 178 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
174 }; 179 };
175 180
176 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 181 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698