chrome/browser/password_manager/chrome_password_manager_client.h - Issue 794133002: [Password Manager] Add UMA signals to understand how often the password form submit navigate…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 794133002: [Password Manager] Add UMA signals to understand how often the password form submit navigate… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nits. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/password_manager/chrome_password_manager_client.h

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h

index bae9ce24b7ac5cda3806a767fbfeeee70744d673..0f75569a023d9e838f797f97129441375bd30382 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.h

+++ b/chrome/browser/password_manager/chrome_password_manager_client.h

@@ -76,6 +76,7 @@ class ChromePasswordManagerClient

bool IsOffTheRecord() override;

password_manager::PasswordManager* GetPasswordManager() override;

autofill::AutofillManager* GetAutofillManagerForMainFrame() override;

+ const GURL& GetMainFrameURL() override;

// Hides any visible generation UI.

void HidePasswordGenerationPopup();

« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')