Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 794133002: [Password Manager] Add UMA signals to understand how often the password form submit navigate… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_manager_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d130d21c84a688be7cf67d56babefed1cace298f..0a7eb4501a7d1a03ef01f33d46fc34fb92abe503 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -22996,6 +22996,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="PasswordManager.SubmitNavigatesToDifferentDomain"
Ilya Sherman 2014/12/15 19:31:14 I think "origin" is a better term than "domain", u
Pritam Nikam 2014/12/16 07:16:52 Done.
vabr (Chromium) 2014/12/16 10:53:37 Actually, this signal does measure something diffe
Ilya Sherman 2014/12/16 19:56:26 Ah, thanks for correcting me. In that case, "doma
+ enum="Boolean">
Ilya Sherman 2014/12/15 19:31:14 Please define and use a custom enumeration, with t
Pritam Nikam 2014/12/16 07:16:52 Done.
+ <owner>vabr@chromium.org</owner>
+ <summary>
+ Indicates whether submitting a password login form changes the registry
+ controlled domain of the main frame.
+ </summary>
+</histogram>
+
<histogram name="PasswordManager.SyncCredentialFiltered" enum="Boolean">
<owner>gcasto@chromium.org</owner>
<owner>vabr@chromium.org</owner>
« no previous file with comments | « components/password_manager/core/browser/password_manager_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698