Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 794003003: Fix GpuLayerCacheTest compile error (Closed)

Created:
6 years ago by Kimmo Kinnunen
Modified:
6 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@webpages-replay-filesystem
Project:
skia
Visibility:
Public.

Description

Fix GpuLayerCacheTest compile error Fix GpuLayerCacheTest compile error: GpuLayerCacheTest.cpp:120:34: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] gcc --version gcc (Ubuntu/Linaro 4.6.4-1ubuntu1~12.04) 4.6.4 Committed: https://skia.googlesource.com/skia/+/b5f4961b30c99afa15775d63df6b605aaecdced8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/GpuLayerCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
6 years ago (2014-12-12 06:13:07 UTC) #2
robertphillips
lgtm
6 years ago (2014-12-12 13:16:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794003003/1
6 years ago (2014-12-12 13:17:18 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-12 13:29:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b5f4961b30c99afa15775d63df6b605aaecdced8

Powered by Google App Engine
This is Rietveld 408576698