Issue 79363004: Merge 235370 "Destroy ExternalCacheDispatcher when last External..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79363004: Merge 235370 "Destroy ExternalCacheDispatcher when last External..." (Closed)

Created:
7 years, 1 month ago by matthewyuan

Modified:
7 years, 1 month ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1700/src/

Visibility:
Public.

More Reviews

Description

Merge 235370 "Destroy ExternalCacheDispatcher when last External..." > Destroy ExternalCacheDispatcher when last ExternalPrefCacheLoader is destroying > > ExternalCacheDispatcher can't be singleton because it needs to be destroyed when IO > is alive. See crbug.com/316983 for details about life time problem. > > + Keep URLRequestContextGetter in ExtensionDownloader as scoped_refptr > > BUG=316983 > TEST=manual > > Review URL: https://codereview.chromium.org/60203011 TBR=dpolukhin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236321

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -12 lines)			Patch
M	chrome/browser/chromeos/extensions/external_pref_cache_loader.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/external_pref_cache_loader.cc	View	6 chunks	+23 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/updater/extension_downloader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/updater/extension_downloader.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r236321.

Expand Messages | Collapse Messages