Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 60203011: Destroy ExternalCacheDispatcher when last ExternalPrefCacheLoader is destroying (Closed)

Created:
7 years, 1 month ago by Dmitry Polukhin
Modified:
7 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Destroy ExternalCacheDispatcher when last ExternalPrefCacheLoader is destroying ExternalCacheDispatcher can't be singleton because it needs to be destroyed when IO is alive. See crbug.com/316983 for details about life time problem. + Keep URLRequestContextGetter in ExtensionDownloader as scoped_refptr BUG=316983 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235370

Patch Set 1 #

Patch Set 2 : fix compilation with clang #

Patch Set 3 : fix compilation for real #

Patch Set 4 : fixed one more nit with clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M chrome/browser/chromeos/extensions/external_pref_cache_loader.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/external_pref_cache_loader.cc View 1 2 3 7 chunks +23 lines, -11 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Dmitry Polukhin
PTAL
7 years, 1 month ago (2013-11-13 22:37:53 UTC) #1
Dmitry Polukhin
fix compilation with clang
7 years, 1 month ago (2013-11-14 06:03:51 UTC) #2
Joao da Silva
lgtm
7 years, 1 month ago (2013-11-14 09:03:55 UTC) #3
Dmitry Polukhin
Marijn, please do OWNER review for extensions code.
7 years, 1 month ago (2013-11-14 16:47:21 UTC) #4
Marijn Kruisselbrink
lgtm
7 years, 1 month ago (2013-11-14 18:38:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/60203011/280001
7 years, 1 month ago (2013-11-14 18:44:14 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=58319
7 years, 1 month ago (2013-11-14 20:21:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/60203011/550001
7 years, 1 month ago (2013-11-14 20:51:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/60203011/550001
7 years, 1 month ago (2013-11-14 21:54:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/60203011/550001
7 years, 1 month ago (2013-11-15 01:25:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/60203011/550001
7 years, 1 month ago (2013-11-15 03:53:29 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=224803
7 years, 1 month ago (2013-11-15 06:28:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/60203011/550001
7 years, 1 month ago (2013-11-15 17:05:38 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-11-15 17:53:18 UTC) #14
Message was sent while issue was closed. 
Change committed as 235370

Powered by Google App Engine
This is Rietveld 408576698