Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 793573006: Refactoring for merging ManagedTileState into Tile. (Closed)

Created:
6 years ago by JungJik
Modified:
6 years ago
Reviewers:
reveman, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring for merging ManagedTileState into Tile. ManagedTileState has mainly two RasterTask and DrawInfo classes. When TileManager get DrawInfo from tile, it should get the state through referencing ManagedTileState. this makes a redundancy reference. This patch removes ManagedTileState and makes DrawInfo to separated files(tile_draw_info). In addition, a tile has raster_task. Committed: https://crrev.com/a4496710ef3f0517ff31f078edbb7d2bd27feafd Cr-Commit-Position: refs/heads/master@{#309351}

Patch Set 1 #

Patch Set 2 : rename HasResources to HasResource #

Total comments: 6

Patch Set 3 : fix trailing_underscore_ and remove duplicated function. #

Total comments: 2

Patch Set 4 : fix a nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -265 lines) Patch
M cc/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/cc.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 3 5 chunks +9 lines, -9 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D cc/resources/managed_tile_state.h View 1 chunk +0 lines, -101 lines 0 comments Download
D cc/resources/managed_tile_state.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/raster_source.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/resources/tile.h View 1 2 3 5 chunks +14 lines, -17 lines 0 comments Download
M cc/resources/tile.cc View 1 2 2 chunks +13 lines, -9 lines 0 comments Download
A cc/resources/tile_draw_info.h View 1 chunk +80 lines, -0 lines 0 comments Download
A cc/resources/tile_draw_info.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M cc/resources/tile_manager.h View 2 chunks +3 lines, -5 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 2 11 chunks +36 lines, -48 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/tiling_set_eviction_queue.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
JungJik
PTAL. thanks.
6 years ago (2014-12-18 12:45:03 UTC) #2
vmpstr
https://codereview.chromium.org/793573006/diff/20001/cc/resources/tile.h File cc/resources/tile.h (right): https://codereview.chromium.org/793573006/diff/20001/cc/resources/tile.h#newcode99 cc/resources/tile.h:99: bool HasActiveTask() const { return raster_task.get() != 0; } ...
6 years ago (2014-12-18 21:34:13 UTC) #3
JungJik
https://codereview.chromium.org/793573006/diff/20001/cc/resources/tile.h File cc/resources/tile.h (right): https://codereview.chromium.org/793573006/diff/20001/cc/resources/tile.h#newcode99 cc/resources/tile.h:99: bool HasActiveTask() const { return raster_task.get() != 0; } ...
6 years ago (2014-12-19 10:06:51 UTC) #4
vmpstr
lgtm https://codereview.chromium.org/793573006/diff/40001/cc/resources/tile.h File cc/resources/tile.h (right): https://codereview.chromium.org/793573006/diff/40001/cc/resources/tile.h#newcode99 cc/resources/tile.h:99: bool HasRasterTask() const { return !!raster_task_.get(); } nit: ...
6 years ago (2014-12-19 22:44:19 UTC) #5
JungJik
https://codereview.chromium.org/793573006/diff/40001/cc/resources/tile.h File cc/resources/tile.h (right): https://codereview.chromium.org/793573006/diff/40001/cc/resources/tile.h#newcode99 cc/resources/tile.h:99: bool HasRasterTask() const { return !!raster_task_.get(); } On 2014/12/19 ...
6 years ago (2014-12-20 13:15:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793573006/60001
6 years ago (2014-12-20 13:38:18 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-20 16:08:49 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-20 16:10:19 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a4496710ef3f0517ff31f078edbb7d2bd27feafd
Cr-Commit-Position: refs/heads/master@{#309351}

Powered by Google App Engine
This is Rietveld 408576698