Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 793453004: Reland of "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allo… (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland of "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name."

Patch Set 1 #

Patch Set 2 : Post-rebase fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -109 lines) Patch
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 5 chunks +14 lines, -4 lines 0 comments Download
M src/objects.cc View 1 20 chunks +58 lines, -57 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +27 lines, -16 lines 0 comments Download
M src/objects-inl.h View 5 chunks +34 lines, -12 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/transitions.h View 3 chunks +39 lines, -2 lines 0 comments Download
M src/transitions.cc View 1 5 chunks +57 lines, -5 lines 0 comments Download
M src/transitions-inl.h View 3 chunks +67 lines, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-transitions.cc View 1 chunk +283 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-430846.js View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Igor Sheludko
PTAL. This is a clean reland of https://codereview.chromium.org/661133002 with minor post-rebase changes.
6 years ago (2014-12-10 13:42:34 UTC) #2
Jakob Kummerow
lgtm
6 years ago (2014-12-10 14:38:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/793453004/20001
6 years ago (2014-12-10 14:55:06 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-10 15:18:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698