Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/hydrogen.cc

Issue 793453004: Reland of "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allo… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Post-rebase fixes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/globals.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 6128 matching lines...) Expand 10 before | Expand all | Expand 10 after
6139 name_.is_identical_to(isolate()->factory()->prototype_string())) { 6139 name_.is_identical_to(isolate()->factory()->prototype_string())) {
6140 return IsLoad(); 6140 return IsLoad();
6141 } 6141 }
6142 if (!LookupDescriptor()) return false; 6142 if (!LookupDescriptor()) return false;
6143 if (IsFound()) return IsLoad() || !IsReadOnly(); 6143 if (IsFound()) return IsLoad() || !IsReadOnly();
6144 if (!LookupInPrototypes()) return false; 6144 if (!LookupInPrototypes()) return false;
6145 if (IsLoad()) return true; 6145 if (IsLoad()) return true;
6146 6146
6147 if (IsAccessor()) return true; 6147 if (IsAccessor()) return true;
6148 Handle<Map> map = this->map(); 6148 Handle<Map> map = this->map();
6149 map->LookupTransition(NULL, *name_, &lookup_); 6149 map->LookupTransition(NULL, *name_, NONE, &lookup_);
6150 if (lookup_.IsTransitionToField() && map->unused_property_fields() > 0) { 6150 if (lookup_.IsTransitionToField() && map->unused_property_fields() > 0) {
6151 // Construct the object field access. 6151 // Construct the object field access.
6152 int descriptor = transition()->LastAdded(); 6152 int descriptor = transition()->LastAdded();
6153 int index = 6153 int index =
6154 transition()->instance_descriptors()->GetFieldIndex(descriptor) - 6154 transition()->instance_descriptors()->GetFieldIndex(descriptor) -
6155 map->inobject_properties(); 6155 map->inobject_properties();
6156 PropertyDetails details = 6156 PropertyDetails details =
6157 transition()->instance_descriptors()->GetDetails(descriptor); 6157 transition()->instance_descriptors()->GetDetails(descriptor);
6158 Representation representation = details.representation(); 6158 Representation representation = details.representation();
6159 access_ = HObjectAccess::ForField(map, index, representation, name_); 6159 access_ = HObjectAccess::ForField(map, index, representation, name_);
(...skipping 7208 matching lines...) Expand 10 before | Expand all | Expand 10 after
13368 if (ShouldProduceTraceOutput()) { 13368 if (ShouldProduceTraceOutput()) {
13369 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13369 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13370 } 13370 }
13371 13371
13372 #ifdef DEBUG 13372 #ifdef DEBUG
13373 graph_->Verify(false); // No full verify. 13373 graph_->Verify(false); // No full verify.
13374 #endif 13374 #endif
13375 } 13375 }
13376 13376
13377 } } // namespace v8::internal 13377 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/globals.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698