Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1900)

Unified Diff: sky/engine/public/web/WebFrameClient.h

Issue 793393003: Move the call to mojo::View::Embed to HTMLIFrameElement (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/loader/FrameLoaderClient.h ('k') | sky/engine/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/public/web/WebFrameClient.h
diff --git a/sky/engine/public/web/WebFrameClient.h b/sky/engine/public/web/WebFrameClient.h
index 18c3e6a8dfbd56ad6586eea5b5e7b01ddd5a041c..1721bf05ec04e7be95d36d6e3e5d57c262b70773 100644
--- a/sky/engine/public/web/WebFrameClient.h
+++ b/sky/engine/public/web/WebFrameClient.h
@@ -69,7 +69,7 @@ public:
// until frameDetached() is called on it.
// Note: If you override this, you should almost certainly be overriding
// frameDetached().
- virtual mojo::View* createChildFrame(const WebURL& url) { return nullptr; }
+ virtual mojo::View* createChildFrame() { return nullptr; }
// This frame has been detached from the view, but has not been closed yet.
// TODO(mpcomplete): reuse these.
« no previous file with comments | « sky/engine/core/loader/FrameLoaderClient.h ('k') | sky/engine/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698