Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart

Issue 793373004: Don't send a refactoring feedback in case of a fatal initial problem. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart b/pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart
index bc8b6cc751b8a9f246427051b20aaba156f594a2..db4a50ae6363f79562585fc9653d162d5f9d8167 100644
--- a/pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart
+++ b/pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart
@@ -54,7 +54,9 @@ class StatementAnalyzer extends SelectionAnalyzer {
* Records fatal error with given message and [Location].
*/
void invalidSelection(String message, [Location context]) {
- _status.addFatalError(message, context);
+ if (!_status.hasFatalError) {
+ _status.addFatalError(message, context);
+ }
reset();
}
« no previous file with comments | « pkg/analysis_server/lib/src/edit/edit_domain.dart ('k') | pkg/analysis_server/test/edit/refactoring_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698