Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 793373004: Don't send a refactoring feedback in case of a fatal initial problem. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/edit/edit_domain.dart
diff --git a/pkg/analysis_server/lib/src/edit/edit_domain.dart b/pkg/analysis_server/lib/src/edit/edit_domain.dart
index ad085755c79d5d39066baa512739524cb92780c5..eb4bbf4168048e48f85e8edb1dc7d178282fc1c9 100644
--- a/pkg/analysis_server/lib/src/edit/edit_domain.dart
+++ b/pkg/analysis_server/lib/src/edit/edit_domain.dart
@@ -254,6 +254,7 @@ class _RefactoringManager {
var params = new EditGetRefactoringParams.fromRequest(request);
_init(params.kind, params.file, params.offset, params.length).then((_) {
if (initStatus.hasFatalError) {
+ feedback = null;
return _sendResultResponse();
}
// set options
@@ -453,9 +454,7 @@ class _RefactoringManager {
}
void _sendResultResponse() {
- if (feedback != null) {
- result.feedback = feedback;
- }
+ result.feedback = feedback;
// set problems
result.initialProblems = initStatus.problems;
result.optionsProblems = optionsStatus.problems;
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698