IDL: Properly support [Exposed] on static methods

Source/bindings/scripts/v8_interface.py

Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index 1d28ad14eb8d1ece2bb648348e6ab99c43e00b12..0a2ae57605eb27bec6760306fcf570d1319baaf2 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -380,10 +380,13 @@ def interface_context(interface):
             runtime_enabled_function = method['runtime_enabled_function']
             has_custom_registration = method['has_custom_registration']
 
+        if has_custom_registration:
+            custom_registration_methods.append(method)
+            continue
         if per_context_enabled_function or conditionally_exposed_function:
             conditionally_enabled_methods.append(method)
             continue
-        if runtime_enabled_function or has_custom_registration:
+        if runtime_enabled_function:
             custom_registration_methods.append(method)

[Jens Widell, 2014/12/15 12:22:34]

So, I split 'has_custom_registration' away from 'runtime_enabled_function' here,
so that the former takes priority over 'per_context_enabled_function' and
'conditionally_exposed_function' but not the latter.

If I had just changed the order of the existing if statements, runtime enabled
*and* per context enabled or conditionally exposed methods would have moved from
conditionally enabled (installConditionallyEnabledMethods()) to custom
registration. The primary difference, I think, is that the former does
prototypeObject->Set() and the latter uses V8DOMConfiguration::installMethod()
and installs the method on the prototype template. I'm not entirely sure what
the difference between those two alternatives is in practice.

Anyway, doing it this way minimizes impact. Current real IDL have no methods
affected by this change, so no CG changes. Test IDL files have some
conditionally exposed static methods that are now treated differently
(correctly) and that's the only thing that changes. If I had changed the order
of the if statement, quite a lot of more things would have changed, both in the
tests and the real generated code.

             continue
         if method['should_be_exposed_to_script']: