IDL: Properly support [Exposed] on static methods

Source/bindings/scripts/v8_interface.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 # coding=utf-8
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 362 matching lines @@
             has_custom_registration = (overloads['has_custom_registration_all'] or
                                        overloads['runtime_determined_lengths'])
         else:
             if not method['visible']:
                 continue
             per_context_enabled_function = method['per_context_enabled_function']
             conditionally_exposed_function = method['exposed_test']
             runtime_enabled_function = method['runtime_enabled_function']
             has_custom_registration = method['has_custom_registration']
 
+        if has_custom_registration:
+            custom_registration_methods.append(method)
+            continue
         if per_context_enabled_function or conditionally_exposed_function:
             conditionally_enabled_methods.append(method)
             continue
-        if runtime_enabled_function or has_custom_registration:
+        if runtime_enabled_function:
             custom_registration_methods.append(method)

[Jens Widell, 2014/12/15 12:22:34]

So, I split 'has_custom_registration' away from 'runtime_enabled_function' here,
so that the former takes priority over 'per_context_enabled_function' and
'conditionally_exposed_function' but not the latter.

If I had just changed the order of the existing if statements, runtime enabled
*and* per context enabled or conditionally exposed methods would have moved from
conditionally enabled (installConditionallyEnabledMethods()) to custom
registration. The primary difference, I think, is that the former does
prototypeObject->Set() and the latter uses V8DOMConfiguration::installMethod()
and installs the method on the prototype template. I'm not entirely sure what
the difference between those two alternatives is in practice.

Anyway, doing it this way minimizes impact. Current real IDL have no methods
affected by this change, so no CG changes. Test IDL files have some
conditionally exposed static methods that are now treated differently
(correctly) and that's the only thing that changes. If I had changed the order
of the if statement, quite a lot of more things would have changed, both in the
tests and the real generated code.

             continue
         if method['should_be_exposed_to_script']:
             method_configuration_methods.append(method)
 
     for method in methods:
         # The value of the Function object’s “length” property is a Number
         # determined as follows:
         # 1. Let S be the effective overload set for regular operations (if the
         # operation is a regular operation) or for static operations (if the
         # operation is a static operation) with identifier id on interface I and
@@ skipping 862 matching lines @@
         deleter = next(
             method
             for method in interface.operations
             if ('deleter' in method.specials and
                 len(method.arguments) == 1 and
                 str(method.arguments[0].idl_type) == 'DOMString'))
     except StopIteration:
         return None
 
     return property_deleter(deleter)