Win32k lockdown: move to chrome://flags, add UMA, add finch

Win32k lockdown: move to chrome://flags, add UMA, add Finch.

Supplying via command line is not sustainable because shortcuts are sometimes sanitized, so moving to a flag so a persistent state can be set.

Also add a Finch experiment to enable win32k lockdown, and an UMA metric to report when it's enabled (either by Finch or flags)

BUG=365160
Committed: https://crrev.com/d672334761063024f795f7b815856817aa822a0a
Cr-Commit-Position: refs/heads/master@{#307953}

[Will Harris, 2014-12-10 21:00:51]

wfh@chromium.org changed reviewers:
+ ananta@chromium.org, jam@chromium.org

[Will Harris, 2014-12-10 21:01:45]

wfh@chromium.org changed reviewers:
+ asvitkine@chromium.org, jschuh@chromium.org

[Will Harris, 2014-12-10 22:15:47]

wfh@chromium.org changed reviewers:
- ananta@chromium.org

[Will Harris, 2014-12-10 22:15:48]

asvitkine: histograms
jschuh: sandbox_win.cc
jam: everything else

cc ananta for info

[Alexei Svitkine (slow), 2014-12-10 22:42:28]

histograms and field trial code lgtm % a suggestion

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
content/public/common/content_switches.cc:1008: if
(CommandLine::ForCurrentProcess()->HasSwitch(
Nit: Maybe put CommandLine::ForCurrentProcess() in a local var to make these not
wrap.

[jschuh, 2014-12-11 18:05:19]

lgtm in principle, and for sandbox_win

[jam, 2014-12-11 18:08:53]

lgtm

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
content/public/common/content_switches.h:297: CONTENT_EXPORT extern const char
kDisableWin32kRendererLockDown[];
nit: sort

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
content/public/common/content_switches.h:301: CONTENT_EXPORT bool
Win32kRendererLockdownEnabled();
nit: begin method name with Is

[Will Harris, 2014-12-11 18:35:58]

thanks for all the reviews

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
content/public/common/content_switches.cc:1008: if
(CommandLine::ForCurrentProcess()->HasSwitch(
On 2014/12/10 22:42:28, asvitkine (OOO Dec13 - Jan4) wrote:
> Nit: Maybe put CommandLine::ForCurrentProcess() in a local var to make these
not
> wrap.

Done.

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
content/public/common/content_switches.h:297: CONTENT_EXPORT extern const char
kDisableWin32kRendererLockDown[];
On 2014/12/11 18:08:53, jam wrote:
> nit: sort

Done.

https://codereview.chromium.org/792873004/diff/40001/content/public/common/co...
content/public/common/content_switches.h:301: CONTENT_EXPORT bool
Win32kRendererLockdownEnabled();
On 2014/12/11 18:08:53, jam wrote:
> nit: begin method name with Is

Done.

[Will Harris, 2014-12-11 18:36:57]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2014-12-11 18:37:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792873004/60001

[commit-bot: I haz the power, 2014-12-11 19:51:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-11 19:51:48]

Patchset 4 (id:??) landed as
https://crrev.com/d672334761063024f795f7b815856817aa822a0a
Cr-Commit-Position: refs/heads/master@{#307953}