Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4589)

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 792873004: Win32k lockdown: move to chrome://flags, add UMA, add finch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main_win.cc
diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc
index 872bc84cc02ca2190d63e7b51f65f784547003cc..946d178e0a58a77d407b512a87fc86b601303452 100644
--- a/chrome/browser/chrome_browser_main_win.cc
+++ b/chrome/browser/chrome_browser_main_win.cc
@@ -237,8 +237,7 @@ int ChromeBrowserMainPartsWin::PreCreateThreads() {
// launched for the plugin does not have the Win32K lockdown mode enabled.
// TODO(ananta)
// Revisit this when the pdf plugin uses skia and stops using GDI.
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableWin32kRendererLockDown) &&
+ if (switches::IsWin32kRendererLockdownEnabled() &&
base::win::GetVersion() >= base::win::VERSION_WIN8) {
CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableOutOfProcessPdf);
@@ -275,6 +274,8 @@ void ChromeBrowserMainPartsWin::PostBrowserStart() {
ChromeBrowserMainParts::PostBrowserStart();
UMA_HISTOGRAM_BOOLEAN("Windows.Tablet", base::win::IsTabletDevice());
+ UMA_HISTOGRAM_BOOLEAN("Windows.Win32kRendererLockdown",
+ switches::IsWin32kRendererLockdownEnabled());
// Set up a task to verify installed modules in the current process. Use a
// delay to reduce the impact on startup time.
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698