Minor fixes for distance field fonts:

Minor fixes for distance field fonts:
- Remove additional transform in drawpostext()
- Use bitmap fonts if rasterizer set in paint
- Correctly set scale ratio for drawtext()

Committed: http://code.google.com/p/skia/source/detail?r=12338

[jvanverth1, 2013-11-20 22:08:10]

I'm about to refactor how the distance fields get set up -- this is just to make
sure the baseline is closer to correct so I have something to compare to.

[bsalomon, 2013-11-20 22:18:05]

lgtm w/ a nit and a q.

https://codereview.chromium.org/79283004/diff/1/src/core/SkDraw.cpp
File src/core/SkDraw.cpp (right):

https://codereview.chromium.org/79283004/diff/1/src/core/SkDraw.cpp#newcode2005
src/core/SkDraw.cpp:2005: const SkMatrix* ctm = fMatrix;
Would it be simpler to turn this into:

const SkMatrix* ctm = fMatrix;
#if SK_DISTANCEFIELD_FONTS

and remove the #if below?

TextMapState       tms(*ctm, constY);

https://codereview.chromium.org/79283004/diff/1/src/core/SkDraw.cpp#newcode2007
src/core/SkDraw.cpp:2007: identity.setIdentity();
setIdentity() should probably be marked deprecated. Most of the code uses the
equivalent reset(). setIdentity() was added to make some Gr code compile when
GrMatrix merged with SkMatrix. Also, there is a global identity matrix,
SkMatrix::I()

[jvanverth1, 2013-11-21 14:25:39]

https://codereview.chromium.org/79283004/diff/1/src/core/SkDraw.cpp
File src/core/SkDraw.cpp (right):

https://codereview.chromium.org/79283004/diff/1/src/core/SkDraw.cpp#newcode2005
src/core/SkDraw.cpp:2005: const SkMatrix* ctm = fMatrix;
On 2013/11/20 22:18:06, bsalomon wrote:
> Would it be simpler to turn this into:
> 
> const SkMatrix* ctm = fMatrix;
> #if SK_DISTANCEFIELD_FONTS
> 
> and remove the #if below?
> 
> TextMapState       tms(*ctm, constY);

My plan is to rip out all of the distance field code from SkDraw, so I'd rather
leave it so I can restore it to the original version.

https://codereview.chromium.org/79283004/diff/1/src/core/SkDraw.cpp#newcode2007
src/core/SkDraw.cpp:2007: identity.setIdentity();
On 2013/11/20 22:18:06, bsalomon wrote:
> setIdentity() should probably be marked deprecated. Most of the code uses the
> equivalent reset(). setIdentity() was added to make some Gr code compile when
> GrMatrix merged with SkMatrix. Also, there is a global identity matrix,
> SkMatrix::I()
> 

Done.

[commit-bot: I haz the power, 2013-11-21 14:26:33]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jvanverth@google.com/79283004/90001

[commit-bot: I haz the power, 2013-11-21 15:09:36]

Change committed as 12338