Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792813002: Restructure public side of surfaces service. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restructure public side of surfaces service. This CL goes from this: //mojo/services/public/cpp/surfaces //mojo/services/public/interfaces/surfaces to this: //mojo/services/surfaces/public/cpp //mojo/services/surfaces/public/interfaces This CL also makes the Mojo-side changes required to roll this change into Chromium. TBR=beng Committed: https://chromium.googlesource.com/external/mojo/+/f893ecb0fbb1f5d7339a3e4b8f50d60393a538c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -523 lines) Patch
M examples/bitmap_uploader/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/ganesh_app/ganesh_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/texture_uploader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/ganesh_app/texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/BUILD.gn View 4 chunks +7 lines, -7 lines 0 comments Download
M examples/surfaces_app/child.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_gl_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/surfaces_app/child_gl_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/surfaces_app/child_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/embedder.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/surfaces_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/aura/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/aura/surface_binding.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/cc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/cc/output_surface_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/cpp/surfaces/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/services/public/cpp/surfaces/surfaces_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/public/cpp/surfaces/surfaces_utils.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/interfaces/surfaces/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/services/public/interfaces/surfaces/quads.mojom View 1 chunk +0 lines, -210 lines 0 comments Download
D mojo/services/public/interfaces/surfaces/surface_id.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/services/public/interfaces/surfaces/surfaces.mojom View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/services/public/interfaces/surfaces/surfaces_service.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 2 chunks +6 lines, -6 lines 0 comments Download
A + mojo/services/surfaces/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A mojo/services/surfaces/public/cpp/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + mojo/services/surfaces/public/cpp/surfaces_utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/surfaces/public/cpp/surfaces_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/surfaces/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/surfaces/public/interfaces/quads.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/surfaces/public/interfaces/surface_id.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/surfaces/public/interfaces/surfaces.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/surfaces/public/interfaces/surfaces_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/view.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M services/native_viewport/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/native_viewport/native_viewport_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/viewport_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/native_viewport/viewport_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/surfaces_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/surfaces_service_application.h View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/surfaces_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/display_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/display_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/view_manager_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/compositor/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/compositor/layer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/compositor/layer_host_client.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/compositor/resource_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/compositor/surface_holder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
blundell
6 years ago (2014-12-10 13:42:08 UTC) #1
blundell
Committed patchset #1 (id:1) manually as f893ecb0fbb1f5d7339a3e4b8f50d60393a538c9 (presubmit successful).
6 years ago (2014-12-10 13:43:32 UTC) #2
Ben Goodger (Google)
6 years ago (2014-12-10 21:34:14 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698