cc/scheduler/scheduler_state_machine.h - Issue 792803008: cc: Split out BeginFrame needed verse proactive for commits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/scheduler_state_machine.h

Issue 792803008: cc: Split out BeginFrame needed verse proactive for commits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renaming methods to be clearer about intentions. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/scheduler_state_machine.h

diff --git a/cc/scheduler/scheduler_state_machine.h b/cc/scheduler/scheduler_state_machine.h

index 0901ca874ddeb6549ea64d8912eb67978ced3e60..44f74f132f30736b01b944a7ff47d4bcf224fdd2 100644

--- a/cc/scheduler/scheduler_state_machine.h

+++ b/cc/scheduler/scheduler_state_machine.h

@@ -248,8 +248,8 @@ class CC_EXPORT SchedulerStateMachine {

}

protected:

- bool BeginFrameNeededToAnimateOrDraw() const;

- bool BeginFrameNeededForChildren() const;

+ bool BeginFrameRequiredForAction() const;

+ bool BeginFrameRequiredForChildren() const;

bool ProactiveBeginFrameWanted() const;

bool ShouldTriggerBeginImplFrameDeadlineImmediately() const;

« no previous file with comments | « no previous file | cc/scheduler/scheduler_state_machine.cc » ('j') | cc/scheduler/scheduler_state_machine.cc » ('J')