components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h - Issue 792803007: Make Data Reduction Proxy a best effort proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

Issue 792803007: Make Data Reduction Proxy a best effort proxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

index 84ab2bc429f491e5d9ab558fda198d321741cb2f..5658dcefb1172ad0b20e26889e079b76e450ada5 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

@@ -39,16 +39,14 @@ bool MaybeBypassProxyAndPrepareToRetry(

DataReductionProxyEventStore* event_store);

// Adds data reduction proxies to |result|, where applicable, if result

-// otherwise uses a direct connection for |url|, the proxy service's effective

-// proxy configuration is not the data reduction proxy configuration, and the

-// data reduction proxy is not bypassed. Also, configures |result| to proceed

-// directly to the origin if |result|'s current proxy is the data

-// reduction proxy, the |net::LOAD_BYPASS_DATA_REDUCTION_PROXY| |load_flag| is

-// set, and the DataCompressionProxyCriticalBypass Finch trial is set.

+// otherwise uses a direct connection for |url|, and the data reduction proxy is

+// not bypassed. Also, configures |result| to proceed directly to the origin if

+// |result|'s current proxy is the data reduction proxy, the

+// |net::LOAD_BYPASS_DATA_REDUCTION_PROXY| |load_flag| is set, and the

+// DataCompressionProxyCriticalBypass Finch trial is set.

void OnResolveProxyHandler(const GURL& url,

int load_flags,

const net::ProxyConfig& data_reduction_proxy_config,

- const net::ProxyConfig& proxy_service_proxy_config,

const net::ProxyRetryInfoMap& proxy_retry_info,

const DataReductionProxyParams* params,

net::ProxyInfo* result);