Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

Issue 792803007: Make Data Reduction Proxy a best effort proxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc
index bfef9e731dba9be6a89018b7fafdfa3147969457..9ed991e10caa19d5b105305a66270ff83429abba 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc
@@ -144,13 +144,16 @@ bool MaybeBypassProxyAndPrepareToRetry(
void OnResolveProxyHandler(const GURL& url,
int load_flags,
const net::ProxyConfig& data_reduction_proxy_config,
- const net::ProxyConfig& proxy_service_proxy_config,
const net::ProxyRetryInfoMap& proxy_retry_info,
const DataReductionProxyParams* params,
net::ProxyInfo* result) {
+ DCHECK(params);
+ DCHECK(result->is_empty() || result->is_direct() ||
+ !params->IsDataReductionProxy(result->proxy_server().host_port_pair(),
+ NULL));
if (data_reduction_proxy_config.is_valid() &&
result->proxy_server().is_direct() &&
- !data_reduction_proxy_config.Equals(proxy_service_proxy_config)) {
+ !url.SchemeIsWSOrWSS()) {
net::ProxyInfo data_reduction_proxy_info;
data_reduction_proxy_config.proxy_rules().Apply(
url, &data_reduction_proxy_info);
@@ -159,12 +162,10 @@ void OnResolveProxyHandler(const GURL& url,
result->UseProxyList(data_reduction_proxy_info.proxy_list());
}
- if (url.SchemeIsWSOrWSS() ||
- ((load_flags & net::LOAD_BYPASS_DATA_REDUCTION_PROXY) &&
- DataReductionProxyParams::IsIncludedInCriticalPathBypassFieldTrial())) {
+ if ((load_flags & net::LOAD_BYPASS_DATA_REDUCTION_PROXY) &&
+ DataReductionProxyParams::IsIncludedInCriticalPathBypassFieldTrial()) {
if (!result->is_empty() &&
!result->is_direct() &&
- params &&
params->IsDataReductionProxy(result->proxy_server().host_port_pair(),
NULL)) {
result->UseDirect();

Powered by Google App Engine
This is Rietveld 408576698