Issue 79263003: Merge 233505 "Tear down IndexedDB dispatcher before WebKit is to..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79263003: Merge 233505 "Tear down IndexedDB dispatcher before WebKit is to..." (Closed)

Created:
7 years, 1 month ago by jsbell

Modified:
7 years, 1 month ago

Reviewers:
jsbell

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1650/src/

Visibility:
Public.

Merge 233505 "Tear down IndexedDB dispatcher before WebKit is to..." > Tear down IndexedDB dispatcher before WebKit is torn down > > Ensure callback objects held by the Indexed DB dispatcher are released > before WebKit and V8 are torn down, since the callback objects hold V8 > handles. > > This is the same patch as crrev.com/50333004 which landed as r232620 > but reverted as r232649 due to timeouts on XP - I just tweaked the > test constants slightly. > > BUG=308988 > TBR=marja@chromium.org,jamesr@chromium.org,dgrogan@chromium.org > > Review URL: https://codereview.chromium.org/58113002 TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236351

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, --1 lines)			Patch
M	content/browser/indexed_db/indexed_db_browsertest.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	content/test/data/indexeddb/shutdown_with_requests.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r236351.