Issue 58113002: Tear down IndexedDB dispatcher before WebKit is torn down

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 58113002: Tear down IndexedDB dispatcher before WebKit is torn down (Closed)

Created:
7 years, 1 month ago by jsbell

Modified:
7 years, 1 month ago

Reviewers:
jamesr, dgrogan, marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Tear down IndexedDB dispatcher before WebKit is torn down Ensure callback objects held by the Indexed DB dispatcher are released before WebKit and V8 are torn down, since the callback objects hold V8 handles. This is the same patch as crrev.com/50333004 which landed as r232620 but reverted as r232649 due to timeouts on XP - I just tweaked the test constants slightly. BUG=308988 TBR=marja@chromium.org,jamesr@chromium.org,dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233505

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -0 lines)			Patch
M	content/browser/indexed_db/indexed_db_browsertest.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	content/test/data/indexeddb/shutdown_with_requests.html	View	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/58113002/1

7 years, 1 month ago (2013-11-06 16:49:39 UTC) #1

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=172482

7 years, 1 month ago (2013-11-06 20:43:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/58113002/1

7 years, 1 month ago (2013-11-06 21:13:51 UTC) #3

Message was sent while issue was closed.

Change committed as 233505

Expand Messages | Collapse Messages