Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 792543003: Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs' (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs' BUG=v8:3663 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -49 lines) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL. I fixed several memory leaks (see issue 3629) that could have caused ASAN bot ...
6 years ago (2014-12-09 13:48:18 UTC) #2
Hannes Payer (out of office)
lgtm
6 years ago (2014-12-09 17:27:51 UTC) #3
mvstanton
Me too. LGTM.
6 years ago (2014-12-10 08:20:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792543003/1
6 years ago (2014-12-10 10:30:54 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-10 10:57:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698