Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: src/heap/objects-visiting-inl.h

Issue 792543003: Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/arm/ic-compiler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_VISITING_INL_H_ 5 #ifndef V8_OBJECTS_VISITING_INL_H_
6 #define V8_OBJECTS_VISITING_INL_H_ 6 #define V8_OBJECTS_VISITING_INL_H_
7 7
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 template <typename StaticVisitor> 256 template <typename StaticVisitor>
257 void StaticMarkingVisitor<StaticVisitor>::VisitCodeTarget(Heap* heap, 257 void StaticMarkingVisitor<StaticVisitor>::VisitCodeTarget(Heap* heap,
258 RelocInfo* rinfo) { 258 RelocInfo* rinfo) {
259 DCHECK(RelocInfo::IsCodeTarget(rinfo->rmode())); 259 DCHECK(RelocInfo::IsCodeTarget(rinfo->rmode()));
260 Code* target = Code::GetCodeFromTargetAddress(rinfo->target_address()); 260 Code* target = Code::GetCodeFromTargetAddress(rinfo->target_address());
261 // Monomorphic ICs are preserved when possible, but need to be flushed 261 // Monomorphic ICs are preserved when possible, but need to be flushed
262 // when they might be keeping a Context alive, or when the heap is about 262 // when they might be keeping a Context alive, or when the heap is about
263 // to be serialized. 263 // to be serialized.
264 if (FLAG_cleanup_code_caches_at_gc && target->is_inline_cache_stub() && 264 if (FLAG_cleanup_code_caches_at_gc && target->is_inline_cache_stub() &&
265 !target->is_call_stub() && 265 !target->is_call_stub() &&
266 (target->ic_state() == MEGAMORPHIC || target->ic_state() == GENERIC || 266 ((heap->flush_monomorphic_ics() && !target->is_weak_stub()) ||
267 target->ic_state() == POLYMORPHIC ||
268 (heap->flush_monomorphic_ics() && !target->is_weak_stub()) ||
269 heap->isolate()->serializer_enabled() || 267 heap->isolate()->serializer_enabled() ||
270 target->ic_age() != heap->global_ic_age() || 268 target->ic_age() != heap->global_ic_age() ||
271 target->is_invalidated_weak_stub())) { 269 target->is_invalidated_weak_stub())) {
272 ICUtility::Clear(heap->isolate(), rinfo->pc(), 270 ICUtility::Clear(heap->isolate(), rinfo->pc(),
273 rinfo->host()->constant_pool()); 271 rinfo->host()->constant_pool());
274 target = Code::GetCodeFromTargetAddress(rinfo->target_address()); 272 target = Code::GetCodeFromTargetAddress(rinfo->target_address());
275 } 273 }
276 heap->mark_compact_collector()->RecordRelocSlot(rinfo, target); 274 heap->mark_compact_collector()->RecordRelocSlot(rinfo, target);
277 StaticVisitor::MarkObject(heap, target); 275 StaticVisitor::MarkObject(heap, target);
278 } 276 }
(...skipping 665 matching lines...) Expand 10 before | Expand all | Expand 10 after
944 942
945 RelocIterator it(this, mode_mask); 943 RelocIterator it(this, mode_mask);
946 for (; !it.done(); it.next()) { 944 for (; !it.done(); it.next()) {
947 it.rinfo()->template Visit<StaticVisitor>(heap); 945 it.rinfo()->template Visit<StaticVisitor>(heap);
948 } 946 }
949 } 947 }
950 } 948 }
951 } // namespace v8::internal 949 } // namespace v8::internal
952 950
953 #endif // V8_OBJECTS_VISITING_INL_H_ 951 #endif // V8_OBJECTS_VISITING_INL_H_
OLDNEW
« no previous file with comments | « no previous file | src/ic/arm/ic-compiler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698