Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792513004: Implement CSSOM smooth scroll for Elements (Closed)

Created:
6 years ago by ajuma
Modified:
6 years ago
Reviewers:
Ian Vollick
CC:
blink-reviews, blink-layers+watch_chromium.org, pdr+renderingwatchlist_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering, rwlbuis
Project:
blink
Visibility:
Public.

Description

Implement CSSOM smooth scroll for Elements This implements smooth scrolling for scroll, scrollTo, scrollBy, scrollTop, and scrollLeft on Elements. Smooth scrolling for scrollIntoView will be added in a later CL. Smooth scrolling is behind a runtime flag. Spec: http://dev.w3.org/csswg/cssom-view/#extensions-to-the-element-interface BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186965

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -99 lines) Patch
M LayoutTests/fast/scroll-behavior/overflow-hidden-scroll-expected.txt View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-hidden-scrollBy-expected.txt View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-hidden-scrollLeft-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-hidden-scrollTo-expected.txt View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-hidden-scrollTop-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-interrupted-scroll-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-scroll-scroll-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-scroll-scrollBy-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-scroll-scrollLeft-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-scroll-scrollTo-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-scroll-scrollTop-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/page/PageAnimator.cpp View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 2 2 chunks +13 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 3 chunks +28 lines, -3 lines 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollAnimator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 2 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ajuma
6 years ago (2014-12-10 21:28:19 UTC) #2
Ian Vollick
On 2014/12/10 21:28:19, ajuma wrote: Looks awesome! LGTM!
6 years ago (2014-12-11 16:57:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792513004/40001
6 years ago (2014-12-11 16:58:23 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 17:01:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186965

Powered by Google App Engine
This is Rietveld 408576698