Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: Source/core/dom/Element.cpp

Issue 792513004: Implement CSSOM smooth scroll for Elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index 5b26c23442273a9edda00c8c8584103880b59d26..95d6824d5e7e8884895744412924fe18f00ce21b 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -806,8 +806,7 @@ void Element::scrollRenderBoxBy(const ScrollToOptions& scrollToOptions)
double currentScaledTop = rend->scrollTop();
double newScaledLeft = left * rend->style()->effectiveZoom() + currentScaledLeft;
double newScaledTop = top * rend->style()->effectiveZoom() + currentScaledTop;
- // FIXME: Use scrollBehavior to decide whether to scroll smoothly or instantly.
- rend->scrollToOffset(DoubleSize(newScaledLeft, newScaledTop));
+ rend->scrollToOffset(DoubleSize(newScaledLeft, newScaledTop), scrollBehavior);
}
}
@@ -828,8 +827,7 @@ void Element::scrollRenderBoxTo(const ScrollToOptions& scrollToOptions)
scaledLeft = scrollToOptions.left() * rend->style()->effectiveZoom();
if (scrollToOptions.hasTop())
scaledTop = scrollToOptions.top() * rend->style()->effectiveZoom();
- // FIXME: Use scrollBehavior to decide whether to scroll smoothly or instantly.
- rend->scrollToOffset(DoubleSize(scaledLeft, scaledTop));
+ rend->scrollToOffset(DoubleSize(scaledLeft, scaledTop), scrollBehavior);
}
}
« no previous file with comments | « LayoutTests/fast/scroll-behavior/overflow-scroll-scrollTop-expected.txt ('k') | Source/core/frame/FrameView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698