src/v8.h - Issue 792513002: Also ignore NDEBUG for chromium code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8.h

Issue 792513002: Also ignore NDEBUG for chromium code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/v8.h

diff --git a/src/v8.h b/src/v8.h

index 6b7c94ecd8f24c9d7e32c2b98c346c8842b76d8d..4267434e4b6284abb9d03915d7b4ab842f71067f 100644

--- a/src/v8.h

+++ b/src/v8.h

@@ -9,8 +9,8 @@

#ifndef V8_V8_H_

#define V8_V8_H_

-#if defined(GOOGLE3)

-// Google3 special flag handling.

+#if defined(GOOGLE3) || defined(DCHECK_ALWAYS_ON)

+// Google3 and Chromium special flag handling.

#if defined(DEBUG) && defined(NDEBUG)

// V8 only uses DEBUG and whenever it is set we are building a debug

// version of V8. We do not use NDEBUG and simply undef it here for

« no previous file with comments | « no previous file | no next file » | no next file with comments »