Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: src/v8.h

Issue 792513002: Also ignore NDEBUG for chromium code (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // 5 //
6 // Top include for all V8 .cc files. 6 // Top include for all V8 .cc files.
7 // 7 //
8 8
9 #ifndef V8_V8_H_ 9 #ifndef V8_V8_H_
10 #define V8_V8_H_ 10 #define V8_V8_H_
11 11
12 #if defined(GOOGLE3) 12 #if defined(GOOGLE3) || defined(DCHECK_ALWAYS_ON)
13 // Google3 special flag handling. 13 // Google3 and Chromium special flag handling.
14 #if defined(DEBUG) && defined(NDEBUG) 14 #if defined(DEBUG) && defined(NDEBUG)
15 // V8 only uses DEBUG and whenever it is set we are building a debug 15 // V8 only uses DEBUG and whenever it is set we are building a debug
16 // version of V8. We do not use NDEBUG and simply undef it here for 16 // version of V8. We do not use NDEBUG and simply undef it here for
17 // consistency. 17 // consistency.
18 #undef NDEBUG 18 #undef NDEBUG
19 #endif 19 #endif
20 #endif // defined(GOOGLE3) 20 #endif // defined(GOOGLE3)
21 21
22 // V8 only uses DEBUG, but included external files 22 // V8 only uses DEBUG, but included external files
23 // may use NDEBUG - make sure they are consistent. 23 // may use NDEBUG - make sure they are consistent.
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 }; 96 };
97 97
98 98
99 // JavaScript defines two kinds of 'nil'. 99 // JavaScript defines two kinds of 'nil'.
100 enum NilValue { kNullValue, kUndefinedValue }; 100 enum NilValue { kNullValue, kUndefinedValue };
101 101
102 102
103 } } // namespace v8::internal 103 } } // namespace v8::internal
104 104
105 #endif // V8_V8_H_ 105 #endif // V8_V8_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698