Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792513002: Also ignore NDEBUG for chromium code (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Also ignore NDEBUG for chromium code BUG=none R=machenbach@chromium.org LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/v8.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-09 10:14:59 UTC) #1
Michael Achenbach
lgtm
6 years ago (2014-12-09 10:21:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792513002/1
6 years ago (2014-12-09 10:30:03 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-09 10:57:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698