Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792463003: [turbofan] Turn JSToBoolean and JSUnaryNot into pure operators. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn JSToBoolean and JSUnaryNot into pure operators. Also fix the pushing of JSToBoolean into Phis and generalize it to also include pushing into Selects. TEST=cctest,unittests

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -114 lines) Patch
M src/compiler/arm/linkage-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/js-graph.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -1 line 1 comment Download
M src/compiler/js-typed-lowering.cc View 9 chunks +58 lines, -35 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/linkage.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/linkage-impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/mips64/linkage-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 4 chunks +2 lines, -41 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +89 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
PTAL https://codereview.chromium.org/792463003/diff/1/src/compiler/js-typed-lowering.h File src/compiler/js-typed-lowering.h (left): https://codereview.chromium.org/792463003/diff/1/src/compiler/js-typed-lowering.h#oldcode34 src/compiler/js-typed-lowering.h:34: Reduction ReplaceWith(Node* node) { return Reducer::Replace(node); } This ...
6 years ago (2014-12-09 06:47:27 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-09 07:05:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792463003/1
6 years ago (2014-12-09 07:06:42 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-09 07:35:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698